Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: heartbeat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897 ------- Additional Comments From orion@xxxxxxxxxxxxx 2006-03-01 11:24 EST ------- - Big issue: You've changed the user creation: %define fuid $[ $(cat /etc/fedora/usermgmt/baseuid) + 24 ] %define guid $[ $(cat /etc/fedora/usermgmt/basegid) + 24 ] (configure) --with-ccmuser-id=%{fuid} \ %pre /usr/sbin/groupadd -g %{guid} -r haclient &>/dev/null || : /usr/sbin/useradd -u %{fuid} -r -s /sbin/nologin -d /var/lib/heartbeat/cores/hacluster -M \ -c 'heartbeat user' -g haclient hacluster &>/dev/null || : This won't work for several reasons: - /etc/fedora/usermgmt/baseuid/gid can be different on different machines. This is NOT constant across Fedora installs. - Michael Schwendt pointed out that baseuid is not ready for use, and to use fedora-useradd/group add instead. Now it *appears* that heartbeat requires a user id at build time, but the only place I see it used in the code is ./cts/CM_LinuxHAv2.py.in: self.rsh.remote_python_call(node, "os", "system", "chown @HA_CCMUID@ @HA_VARLIBDIR@/heartbeat/crm/cib.xml") which I believe could be changed to: ./cts/CM_LinuxHAv2.py.in: self.rsh.remote_python_call(node, "os", "system", "chown @HA_CCMUSER@ @HA_VARLIBDIR@/heartbeat/crm/cib.xml") since the username will be constant. - After looking at ConfigureMe, you are better off calling %configure with the appropriate options directly: %configure \ --disable-fatal-warnings \ --disable-static \ %if %{ENABLE_MGMT} --enable-mgmt %else --disable-mgmt - You need to fix up your Requires(pre/post/etc), especially when you move back to fedora-useradd/groupadd. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
