Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtomoe-gtk https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172343 ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-02-27 10:55 EST ------- New site downloads much better. One thing still blocking: the devel subpackage needs it's own call to ldconfig. See the ReviewGuidelines on the wiki. Good: - rpmlint checks return: W: libtomoe-gtk-debuginfo objdump-failed Not critical. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales handled by %find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
