Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: par2 - PAR2 recovery set command line utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183067 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-02-26 01:19 EST ------- NEEDSWORK: - package doesn't depend on libsigc++ at all. Please remove "BR: libsigc++-devel" - I don't see any need for 001_hardlinks.patch The original authors want these programs hardlinks, so be it. - Compilation triggers dozens of warnings of this kind: ... par2fileformat.h:67: warning: ignoring packed attribute on unpacked non-POD field 'MD5Hash PACKET_HEADER::hash' par2fileformat.h:68: warning: ignoring packed attribute on unpacked non-POD field 'MD5Hash PACKET_HEADER::setid' par2fileformat.h:79: warning: ignoring packed attribute on unpacked non-POD field 'MD5Hash FILEVERIFICATIONENTRY::hash' par2fileformat.h:86: warning: ignoring packed attribute on unpacked non-POD field 'MD5Hash FILEVERIFICATIONPACKET::fileid' ... In many cases, these warnings can not be ignored. Please check. - The toplevel Makefile.am contains this: LDADD = -lstdc++ This is a BUG. Remove this line. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
