Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: heartbeat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897 ------- Additional Comments From orion@xxxxxxxxxxxxx 2006-02-24 13:11 EST ------- (In reply to comment #23) > > I am not sure I understand what you mean by this. I think you want me to change > this line: > USEROPT="-g haclient -u 17 -d /var/lib/heartbeat/cores/hacluster" > to: > USEROPT="-g haclient -u $[ $(cat /etc/fedora/usermgmt/baseuid) + 17 ] -d > /var/lib/heartbeat/cores/hacluster" > Correct? > Well, if you can live without a fixed user id, drop the '-u 17'. If you need a fixed one, register with http://fedoraproject.org/wiki/Packaging/UserRegistry and use that offset rather than 17. I think I would drop the redirection to /dev/null as well. > > - rpmlint: > > > > # rpmlint heartbeat-pils > > W: heartbeat-pils devel-file-in-non-devel-package /usr/lib/libpils.so > > ^ this should be in heartbeat-devel (or heartbeat-pils-devel) > > > I am unsure what to do here: > * Do *.so files always go in a seperate -devel package or just in this case? > What to do with /usr/lib/pils/plugins/InterfaceMgr/generic.so file? > * You know that /usr/lib/libpils.so symlinks to > /usr/lib/libpils.so.1.0.0; should this also go in -devel package? > .so files always go in -devel (and just the .so links, not the actual libraries). > > E: heartbeat-pils library-without-ldconfig-postin /usr/lib/libpils.so.1.0.0 > > E: heartbeat-pils library-without-ldconfig-postun /usr/lib/libpils.so.1.0.0 > > ^ needs: > > %post pils -p /sbin/ldconfig > > %postun pils -p /sbin/ldconfig > > If these files go to -devel package They don't. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
