Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dap-server - Basic request handling for DAP servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179707 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |ed@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From ed@xxxxxxx 2006-02-15 22:36 EST ------- Hi Patrice, I've been meaning to look at this so, since today is the first scheduled FE "review day", heres a quick review: good: + source matches upstream + license is correctly included + spec is very legible--no obvious errors + builds on FC4 (not in mock) + rpmlint reports: E: dap-server non-standard-uid /var/cache/dap-server apache E: dap-server non-standard-gid /var/cache/dap-server apache W: dap-server-cgi no-documentation E: dap-server-cgi non-standard-uid \ /etc/httpd/conf.d/opendap_apache.conf apache ...and a few more of the same apache uid/gid errors... which can probably be safely ignored + dir ownership is OK + no shared libs + clean(s) are properly done nits: - License is LGPL not GPL - fails to build with "mock -r fedora-development-i386-core $SRPM" and returns the following error message: make[2]: Entering directory `/builddir/build/BUILD/dap-server-3.5.3' if g++ -DHAVE_CONFIG_H -I. -I. -I. -I/usr/include/libdap -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT usage.o -MD -MP -MF ".deps/usage.Tpo" -c -o usage.o usage.cc; \ then mv -f ".deps/usage.Tpo" ".deps/usage.Po"; else rm -f ".deps/usage.Tpo"; exit 1; fi /usr/include/libdap/GNURegex.h:45: error: extra qualification 'Regex::' on member 'init' Do you know whats the matter with devel at the moment? I realize its not a blocker, I'm just curious whats causing the problem -- and don't have a lot of time right now to look at the syntax... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
