Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Log-Log4perl - Log4j implementation for Perl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176137 paul@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |paul@xxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From paul@xxxxxxxxxxxx 2006-02-09 07:43 EST ------- Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, pkgconfigs, or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - no scriptlets - patches look sane Suggestions: - perhaps a comment in the spec file about the issue with Log::Dispatch::FileRotate, and a reference to this bugzilla ticket? - perhaps the rrdtool buildreq could be replaced by perl(RRDs)? Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
