Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svnmailer - Tool to post subversion repository commit information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180319 ------- Additional Comments From mfleming+rpm@xxxxxxxxxxxxxxxx 2006-02-08 04:15 EST ------- (In reply to comment #3) New SRPM: http://www.enlartenment.com/extras/svnmailer-1.0.6-2.src.rpm New SPEC: http://www.enlartenment.com/extras/svnmailer.spec > * I would still prefer a more strict following of the spec template. Use the new > template and fill it with the older information: it would really make it more > readable. Done, hope it's more sensible and legible. > * Change the license to "Apache Software License" so rpmlint likes it. Done. How on earth did I miss that before :-P > * Does it really need subversion as a Buildreq? Interestingly, yes - as it likes the subversion python bindings there during builds (and FC4 has them in the base package...). I've built it before without it and the results are quite erm, *interesting* :-). > Suggestions (non-binding!): > * You may consider separating the documentation into a subpackage. It's large > and it probably won't be useful to most of the users. Done (svnmailer-doc - suggestions on a better subpackage convention welcomed) > * You may also consider running the test suite provided upstream automatically. > Not a bad idea for folks who want to extend or otherwise hack on it, but I'd like to nail the basic package first. TODO. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
