Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nazghul - Old school RPG engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180255 ------- Additional Comments From mfleming+rpm@xxxxxxxxxxxxxxxx 2006-02-07 06:08 EST ------- Builds fine in mock (FC4) and plays well for this old Ultima geek (10yrs+ udic.org member :-)). - rpmlint is mostly happy aside the lack of doco in the haxima subpackage - nazgul-haxima should be noarch - rm $RPM_BUILD_ROOT%{_bindir}/haxima.sh - > rm -f $RPM_BUILD_ROOT.... - Rather than use chmod during %install use %attr in %files (my preference) - install -Dp instead of mkdir/install -p for the haxima icon? - %exclude %{_datadir}/nazghul/haxima in base package - why? - list fedora-haxima.desktop & haxima.png in %files rather than using a wildcard as you probably don't want to own all desktop and pixmap files I'll take this bug for a fuller review a little later (once my bz group membership is sorted) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
