Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnonlin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180298 jeff@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jeff@xxxxxxxxxxxxxxxxx ------- Additional Comments From jeff@xxxxxxxxxxxxxxxxx 2006-02-07 00:08 EST ------- 1. Don't use "%define name". The "Name:" tag implicitly defines the %name macro. 2. Need to BR gettext-devel 3. You don't need gst-register-0.10 in %post and %postun - not necessary anymore in gstreamer 0.10. 5. Delete the %{_libdir}/gstreamer-0.10/libgnl.la in %install 6. The -devel package needs to own %{_includedir}/gnl 7. Use "-p" on the manually installed header files. 8. User "make DESTDIR=$RPM_BUILD_ROOT install" not %makeinstall. 9. Running "aclocal" and "autoconf" in %prep doesn't really seem to be necessary. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
