Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdemulimedia-extras https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176288 ------- Additional Comments From dennis@xxxxxxxx 2006-02-06 13:55 EST ------- -md5sum kdemultimedia-3.5.1.tar.bz2 595f637c637987a92f6dac9d9cd6667d kdemultimedia-3.5.1.tar.bz2 matches values posted at http://kde.org/download/ -rpmlint is ok -package meets naming guidelines -spec file is named correctly -license is acceptable and correct -spec file is in english -package built in mock on devel for x86_64 and i386 extra build requires BuildRequires: libtheora-devel BuildRequires: libvorbis-devel >= 1:1.1.0 only need versioned one. i would also suggest that the commented out patches and defines be removed to clean things up a little. I would personally remove the gtk-update-icon-cache from post as I believe thats not where it belongs, but thats a personal preference and not a blocker. -no duplicate files -file permissions look good -package contains code - bad -package contains .la files -juk does not install .desktop file correctly -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
