Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adplug https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177818 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From bugs.michael@xxxxxxx 2006-02-03 20:08 EST ------- * spec looks good * dependencies 177865 and 178360 build with this * basic run-time testing: works for me * sources match upstream However: I'm unsure with regard to the stuff it does when running "adplugdb" with option "-s". Currently, it cannot create /usr/share/adplug/adplug.db because the directory is missing. And it ought not try writing to a file there anyway, as according to the FHS /usr/share is supposed to be for read-only and platform-independent data. Which leads to a question: Is adplug.db a platform-independent format? The default configuration of adplugdb (and the manual page) would need a correction to use directory /var/lib/adplug instead (or var/lib/misc/adplug.db if only that single file is accessed in there). Which leads to another question: If %dir /var/lib/adplug gets included, what to do with /var/lib/adplug/adplug.db during package removal? If %ghost'ed, user would lose the database file. If not %ghost'ed, the directory could not be removed. I prefer the latter, since I don't like removing user-created data files. In either case, /usr/share/adplug{/adplug.db} as a default is questionable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
