Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jigdo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178169 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-01-29 15:17 EST ------- Here's a review: MUST items: OK Package name. OK Spec file name. OK License good (GPL). OK License in spec matches. OK License is included (GPL COPYING) OK Spec english/readable OK Sources match upstream (md5: 031756ff6c7084a139dc9550a27f6906) OK No packages in BR that are in the exceptions list. OK Correctly uses find_lang OK No dynamic libs, so no ldconfig needed. OK Builds on fc4. OK No rpmlint output (on fc4 build). Good! OK Package owns all it's created directories. OK No duplicate files in files section. OK Permissions look good. OK Clean section looks good. OK desktop file looks good and good install. OK Runs fine on my fc4 machine. ISSUES: 1. Doesn't build in current devel/mock. It has two unavailable BuildRequires: No Package Found for w3c-libwww-devel >= 0:5.3.2 No Package Found for XFree86-devel The w3c-libwww package no longer seems available in core in devel/fc5. XFree86-devel has been replaced with modular xorg packages. You may need to create and import a w3c-libwww package before this one if that support is needed by this package. Can you see if that support is optional, and/or some new package now provides that support for fc5? Also, if you could review/comment on some other in review packages to show your understanding of the package guidelines, that would assist in deciding to sponsor you. ;) You can find a list in bugzilla at: https://bugzilla.redhat.com/bugzilla/showdependencytree.cgi?id=FE-REVIEW&hide_resolved=1 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
