[Bug 179040] Review Request: socat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: socat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179040





------- Additional Comments From somlo@xxxxxxx  2006-01-26 19:26 EST -------
Summary and %description should both start with a capital letter

> %setup -q -n "%{name}-%{mversion}"

use '%setup -q' and get rid of %{mversion}

> export DESTDIR=%{buildroot}
> %{__make} DESTDIR=%{buildroot} install

The 'export DESTDIR' line is redundant, unless you have a broken makefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux