Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Mud Magic Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176200 ------- Additional Comments From kyndig@xxxxxxxxxxxx 2006-01-25 22:16 EST ------- " * Don't use an Epoch: tag if it's going to be "0" " removed " * Use Release: 0.4%{?dist} rather than Release: 0.fdr.4 " used " * Replace "1.8" with "%{version}" in the Source: tag for easier spec maintenance " this is actually already present, the mudmagic.spec is created during configure with mudmagic.spec.in which uses an @VERSION@ variable to output the mudmagic source version " * The %configure macro should set CFLAGS so there's no need to do it yourself " Removed CFLAGS " * Use e.g. "%post -p /sbin/ldconfig" rather than "%post" and "/sbin/ldconfig" on separate lines " Used - and also used for %postun " * Add changelog entries for your changes so it doesn't look like the last change was by Michael Schwendt in 2004 " Added all entries from this ticket with appropriate credits " - Use $RPM_BUILD_ROOT or %{buildroot}, not ${RPM_BUILD_ROOT} " using %{buildroot} now " - libxml2-devel is provided by libglade2-devel " removed libxml2-devel " - Description should be in sentence form (put a period after MudMagic.Com.) " period added " - Requires(post): /sbin/ldconfig - Requires(postun): /sbin/ldconfig " These two requires added " - Mock build failed (Also failed on my machine): " Rewrote the method of --prefix and --exec-prefix handling for autoconf. I won't go into details - but it was a heavy rewrite. included the usage of user defined variables for installation directories opposed to hard coded directory locations in Makefile.am files and configure.in file. Autoconf build system rebuilt and changes commited to CVS. spec: http://www.mudmagic.com/mud-client/downloads/mudmagic.spec srpm: http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8-0.4.src.rpm tarball: http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8.tar.gz Thank you all, Calvin -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
