Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Mud Magic Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176200 ------- Additional Comments From kyndig@xxxxxxxxxxxx 2006-01-25 01:19 EST ------- "A few obvious things that need fixing, there might be more... - %define version 1.8 This is unnecessary, just put the number directly after Version:" done "- Release: does not follow the new Extras guidelines - %{_libdir}/libmudmagic.a %{_libdir}/libmudmagic.la" %excluded "-Source should be http://dl.sourceforge.net/kyndig/%{name}-%{version}.tar.gz" redirected accordingly "-Source must be available at dl.sourceforge.net (currently only 1.7 is)" placed now on dedicated server "-Change Release: see http://fedoraproject.org/wiki/DistTag" Read ..partially =) "Duplicate Build Requires: glib2-devel provided by gtk2-devel pango-devel provided by gtk2-devel pkgconfig provided by glib2-devel gtk2-devel provided by libglade2-devel" unduplicated "-Inconsistant use of RPM_BUILD_ROOT" consisticised(sp?) "-I'd just define version under Version:" defined "-Don't include dist tag in the change log, version-release is fine" eh - tomato, tomahto I could not get this to compile on my FC4 machine. See error below: -------------------------------------- creating libmxp.la (cd .libs && rm -f libmxp.la && ln -s ../libmxp.la libmxp.la) make[2]: *** No rule to make target `../bundled/bundled/pcre/pcre.c', needed by `pcre.lo'. Stop. make[2]: Leaving directory `/home/IES_CHICAGO/mmcgrath/rpm/BUILD/mudmagic-1.8/bundled' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/IES_CHICAGO/mmcgrath/rpm/BUILD/mudmagic-1.8' make: *** [all] Error 2 error: Bad exit status from /home/IES_CHICAGO/mmcgrath/rpm/BUILD/rpm-tmp.45059 (%build) ------------------------------------- Outstanding - thanks for the feedback, I would have missed that. Minor typo fixed. I made these corrections to the autobuild system itself, reran the headers, regenerated the configure, and rebundled the current distro. Again, I am testing my waters with Fedora. I tried this a year ago and failed miserable ( I did read all the docs back then =) I will update this ticket once the final product is released. Please in the meantime; should I have a newb error, let me know. spec: http://www.mudmagic.com/mud-client/downloads/mudmagic.spec srpm: http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8-0.fdr.4.src.rpm tarball: http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8-0.tar.gz Thank you, Calvin -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list