Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ushare https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176618 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-01-19 18:00 EST ------- Good: - rpmlint checks return: E: ushare non-standard-uid /var/lib/ushare ushare E: ushare non-standard-gid /var/lib/ushare ushare E: ushare non-standard-dir-perm /var/lib/ushare 0770 Safe to ignore. - package meets naming guidelines - license (GPL) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file MAJOR BLOCKER: You should not use %{_datadir}/locale/* to grab the locale files. This causes you to own some of the locale directories. Instead, you should use the %find_lang macro like this: (at the end of %install): %find_lang %{name} Then, instead of %files, put: %files -f %{name}.lang Remove %{_datadir}/locale/*, the %{name}.lang will cover it. MINOR BLOCKER: Please uncomment the %doc line. It's valid. :) Show me a package with those blockers resolved, and I'll approve it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
