Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cmucl: CMU Common Lisp compiler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166796 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-01-19 13:54 EST ------- I have a need for cmucl packages, so I figured I'd put in some work into a review. rpmlint output: W: cmucl devel-file-in-non-devel-package /usr/lib/cmucl/internals.h E: cmucl no-signature E: cmucl-extras requires-on-release cmucl 19c-2 W: cmucl-extras no-documentation E: cmucl-extras no-signature Issues: - The single header file that's included in the main package. I can't imagine it's worth creating a separate -devel package for one file, but that would have to be decided by someone more knowledgeable than I. Is it needed for the compiler to operate? - The license. Upstream does not include a separate license text. The specfile indicates "Public Domain", but the README file says "... is mostly in the public domain". Section 1.3 of the manual lists a number of copyright statements; I will include them at the end of this review. An expert will need to make sure these are acceptable, and then decide whether it's reasonable to call the whole "Public Domain". - rpmlint complains "E: cmucl-extras requires-on-release cmucl 19c-2". Unfortunately I don't know what this means. (rpmlint -i provides no explanation.) - rpmlint complains "W: cmucl-extras no-documentation", and indeed there is no documentation included in the package. I think it would be reasonable to explain just what some of this stuff is. At minimum, the %description for the extras package could list what is included. - The spec includes two separate build methods. Are they both needed? - ExclusiveArch: %{ix86} - Is there no portability at all to x86_64 or PPC? - Since the compiler builds itself, the srpm includes a pre-built copy. I believe this is accepted practice but I figured I'd make sure. Here are the copyright statements from the manual: CMUCL's CLOS implementation is derived from the PCL reference implementation written at Xerox PARC: Copyright (c) 1985, 1986, 1987, 1988, 1989, 1990 Xerox Corporation. All rights reserved. Use and copying of this software and preparation of derivative works based upon this software are permitted. Any distribution of this software or derivative works must comply with all applicable United States export control laws. This software is made available AS IS, and Xerox Corporation makes no warranty about the software, its performance or its conformity to any specification. Its implementation of the LOOP macro was derived from code from Symbolics, which was derived from code written at MIT: Portions of LOOP are Copyright (c) 1986 by the Massachusetts Institute of Technology. All Rights Reserved. Permission to use, copy, modify and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the M.I.T. copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation. The names "M.I.T." and "Massachusetts Institute of Technology" may not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. Notice must be given in supporting documentation that copying distribution is by permission of M.I.T. M.I.T. makes no representations about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty. Portions of LOOP are Copyright (c) 1989, 1990, 1991, 1992 by Symbolics, Inc. All Rights Reserved. Permission to use, copy, modify and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the Symbolics copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation. The name "Symbolics" may not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. Notice must be given in supporting documentation that copying distribution is by permission of Symbolics. Symbolics makes no representations about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty. Symbolics, CLOE Runtime, and Minima are trademarks, and CLOE, Genera, and Zetalisp are registered trademarks of Symbolics, Inc. The CLX code is copyrighted by Texas Instruments Incorporated: Copyright (C) 1987 Texas Instruments Incorporated. Permission is granted to any individual or institution to use, copy, modify, and distribute this software, provided that this complete copyright and permission notice is maintained, intact, in all copies and supporting documentation. Texas Instruments Incorporated provides this software "as is" without express or implied warranty. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
