Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Jakarta Commons CLI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178142 chabotc@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-18 08:44 EST ------- Changes look great, here's the completed formal review list: MUST review items: - Builds cleanly on FC5 devel. - rpmlint has no output - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (Apache Software Licence) is fedora extra's compatible & is included in spec - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - No need for ldconfig - All files have proper permissions - Package is not relocatable - No duplicate files in %files section anymore - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - Directory-ownerships is ok now - Not a gui app so no desktop file handling needed Should items: - Includes upstream licence file (COPYING) - No insane scriplets, or scriplets at all - No unnescesarry requires - Mock builds cleanly FE-APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
