Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xkeycaps : Graphical front end to xmodmap https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177946 chabotc@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chabotc@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-16 15:04 EST ------- Compiled cleanly & functions on FC5-devel Missing: .desktop file (Required by PackageReviewGuidelines) or explanation why Missing: (copied from upstream or in package included) licence file, however there is a copyright mentioned in the manpage, not sure if this is 'good enough', will trust packager's judgement on this Review list MUST items: - Builds cleanly on FC5 devel. - rpmlint has no output / complaints - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (BSD-ish?) is fedora extra's compatible - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - No need for ldconfig - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - No directory-ownerships needed Review list SHOULD items: - No insane scriplets - No unnescesarry requires rpmlint has no complaints at all (no output) & mock build cleanly (fc-devel-i386) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
