Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alsamixergui : GUI mixer for ALSA sound devices https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177944 ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-16 14:43 EST ------- Compiled cleanly & functions on FC5-devel One functional comment: There is no quit button (other then window titlebar [X] one), not really an HIG compliant application, but functional otherwise. Missing for formal checklist (from PackageReviewGuidelines): "Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. This is described in detail in the desktop files section of PackagingGuidelines. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation." Review list MUST items: - Builds cleanly on FC5 devel. - rpmlint has no output / complaints - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (BSD-ish?) is fedora extra's compatible & is included in spec - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - No need for ldconfig - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - No directory-ownerships needed Review list SHOULD items: - Includes upstream licence file (COPYING) - No insane scriplets - No unnescesarry requires rpmlint has no complaints at all (no output) Please add a desktop file, or explanation why not in the spec file, and i'll do the reviewlist again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
