Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: RSSOwl - an RSS/RDS/Atom Newsreader https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176982 chabotc@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chabotc@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-16 13:05 EST ------- I'll pick this one up for review. It builds cleanly, however i've not been able to mock build this package since itext hasn't been included in fedora(-extras) yet, but it looks like it should. Functionally it works well for me too. Spec file needs work though, rpmlint becomes mad over a few things: E: rssowl explicit-lib-dependency libgconf-java This is an ignorable error, even though we wish it did, rpm doesn't autodepend this properly, so explicit require should stay. No fix needed E: rssowl description-line-too-long RSSOwl is a RSS / RDF / Atom Newsreader written in Java using SWT as fast graphic library. Read News in a tabfolder, save favorites in categories, Export to PDF / RTF / HTML / OPML, Import Feeds from OPML, perform fulltext-search, use the integrated browser. Please contact bpasero@xxxxxxxxxx if you have any questions or problems regarding this version. Description lines should be wraped at 80 (or even 78) characters, so it fits on any console, please add some wrapping to this text :-) W: rssowl non-standard-group Productivity/Networking/News Please pick one of FE's standard groups and stick to it :-) http://fedoraproject.org/wiki/RPMGroups My suggestion would be "Applications/Internet" for this package. W: rssowl incoherent-version-in-changelog 1.2-6fc 1.2-6 Version entry should be without the 'fc' in the changelog W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/popups.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_usersets.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/faq.xml W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/styles/rssowldocs.css W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_webfeeds.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_subscrips.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_ampheta.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/index.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/LICENSE.txt W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_proxy.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_offline.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/README.txt W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/faq.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/menus.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_browser.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/CHANGELOG.txt W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/quickstart.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/resources.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/dialogs.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_reload.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/rssowl_i18n.template W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/howto.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_searchagg.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/tipstricks.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_manage.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/ht_eximprint.html W: rssowl wrong-file-end-of-line-encoding /usr/share/doc/rssowl-1.2/tutorial/en/elements.html Please add dos2unix (as in the package name) to build requires, and run dos2unix in the spec file on those files; dos2unix does allow * in the files to convert so you could do: dos2unix %{_docdir}/rssowl-1.2/tutorial/en/*.html dos2unix %{_docdir}/rssowl-1.2/tutorial/en/styles/* dos2unix %{_docdir}/rssowl-1.2/tutorial/en/*.html dos2unix %{_docdir}/rssowl-1.2/*.{xml,html,txt,template}} inside the specfile (as last part of the %install section) W: rssowl one-line-command-in-%post /usr/bin/rebuild-gcj-db W: rssowl one-line-command-in-%postun /usr/bin/rebuild-gcj-db You can fix these by making it: %post -p %{_bindir}/rebuild-gcj-db E: rssowl standard-dir-owned-by-package /usr/share/icons (Actually same goes for applications and pixmaps but rpmlint doesn't check these). Please change to atleast: %{_datadir}/applications /* %{_datadir}/pixmaps/* %{_datadir}/icons/* So the package doesn't end up owning the (fedora/freedesktop standard) directories. Please also change the summary, shouldn't start with the package name, better would be: "Free RSS / RDF / Atom Newsreader". Or you could even omit the "Free" part, because it being included in fedora extra's implicitly implies that it IS free, there's no pay-for or not open source software in fedora extra's, so this "free" description applies for every package in FE :-) So even better would be: "An RSS, RDF and Atom Newsreader" For the rest it looks good. Please correct the above described errors and warnings and i'll go thru the complete formal checklist. Changing blocker bug to FE-REVIEW. Feel free to assign the bug to me (not in fedorabugs group yet so can't do this for you) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
