Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adplug https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177818 ------- Additional Comments From bugs.michael@xxxxxxx 2006-01-15 11:48 EST ------- > $ rpmlint adplug-1.5.1-2.20060101cvs.src.rpm > W: adplug summary-ended-with-dot A software library for AdLib > (OPL2) emulation. Headline-style "Software library for AdLib (OPL2) emulation" commonly considered better taste. * %postun script is broken during package removal: /sbin/ldconfig: relative path `0' used to build cache error: %postun(adplug-1.5.1-2.20060101cvs.i386) scriptlet failed, exit status 1 Avoid '#' prefixed comments in your spec file below scriptlet sections. The spec parser inserts them into your scriptlets, which makes them fail badly when your scriptlet interpreter is not a shell, but /sbin/ldconfig. See "rpm --query --scripts adplug". * adplug-devel is missing "Requires: libbinio-devel". See headers which included binio.h and the dependency in the pkgconfig file. * Making good use of "make test" either in %check section or not could turn out to be useful (adplug is not fully portable yet). > # Remove doc "dir" > rm -rf $RPM_BUILD_ROOT%{_infodir}/dir /usr/share/info/dir is an index file, not a directory. Simple "rm -f" ought to be enough. Else it looks good. xmms-adplug is playing fine here (although I had to tell it where to find libbinio headers). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
