Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rtorrent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177636 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |j.w.r.degoede@xxxxxx ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-01-14 15:03 EST ------- Things which need to be changed: -Summary must not start with "A ..." remove "A .." -.so Requires are picked up by rpm automaticly, remove explicit requires -rtorrent.rc.example should be installed with 644 not 664 Possible improvements: -I would change "A client frontend to libtorrent" to "BitTorrent client using libtorrent" Formal Review: MUST review items: - Builds cleanly on FC5 devel. - rpmlint has no output / complaints - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (GPL) is fedora extra's compatible & is included in spec - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - Proper use of ldconfig - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - No directory-ownerships needed Should items: - Includes upstream licence file (COPYING) - No insane scriplets, or scriplets at all - No unnescesarry requires Looks good to me, changing blockerbug to FE-ACCEPT assuming that you will fix all items listed under "Things which need to be changed". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
