Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtorrent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177635 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede@xxxxxx ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-01-14 11:59 EST ------- As requested a review, first look over the specfile while doing a build yields: -Summary must not start with "A ..." remove "A .." -Summary line exceeds 80 chars (nitpick) -Is the requires openssl nescesarry? "ldd /usr/lib64/libtorrent.so" gives: libcrypto.so.6 => /lib64/libcrypto.so.6 (0x00002aaaaac68000) libsigc-2.0.so.0 => /usr/lib64/libsigc-2.0.so.0 (0x00002aaaaaea8000) libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00002aaaaafae000) libm.so.6 => /lib64/libm.so.6 (0x00002aaaab1ab000) libc.so.6 => /lib64/libc.so.6 (0x00002aaaab32d000) libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00002aaaab566000) libdl.so.2 => /lib64/libdl.so.2 (0x00002aaaab674000) libz.so.1 => /usr/lib64/libz.so.1 (0x00002aaaab778000) /lib64/ld-linux-x86-64.so.2 (0x0000555555554000) and "rpm -qf /lib64/libcrypto.so.6" gives: openssl-0.9.8a-5.x86_64 so openssl is already automaticly required, or does it require additonal non .so files provided by openssl? -%package devel, Summary s/envirioment/environment/ -%package devel, Group should be Development/Libraries . -%package devel, Description Header, include files seems a bit double to me. -%files %dir %{_includedir}/torrent %{_includedir}/torrent/*.h can be replaced by just (nitpick again) %{_includedir}/torrent rpm will then own that dir and pickup all files under it automaticly It compiles without an warnings on 64bit, good! rpmlint also likes it. Please fix the above and I'll do a full review soon. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
