Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-sqlite2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176653 ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-14 07:53 EST ------- Licence: Can't comment on but if thats the licence they specify then who are we to complain? Looking at http://www.zlib.net/zlib_license.html its more then free enough :-) Package name: normally you would follow the upstream naming, but given that the Core package is called python-sqlite calling it python-sqlite2 is the proper thing to do to avoid confusion Personally i'd make the identation of the Requires: line the same as of the other header fields, but thats my perfectionistic nature :-) Shouldn't sqlite-devel >= 3.0.0 be in the build requires for clarity? - rpmlint output: W: python-sqlite2 invalid-license zlib/libpng As discussed above, i think its safe to ignore, we don't get to choose the licence, authors do that - Package follows naming guidelines - Specfile is in %{name} format - Follows PackagingGuidelines - Licence is Opensource - License field in the package spec file matches the actual license - Incluses licence from source tarbal - In american english - And legible - md5sum matches with upstream download, and specfile url + d/l entry is valid - Build successfully on atleast i386 (tested) into binary rpm - Buildrequires is valid, but misses sqlite-devel (>= 3.0.0) entry! Above makes build in mock build fail with: In file included from src/module.c:24: src/connection.h:32:21: error: sqlite3.h: No such file or directory ... etc etc ... - Has no .so or locales so no macro's needed for it - Owns directories it created - No duplicate files - Has proper %clean section - Uses macro's consitently (as far as aplicable, pythoning is not done thru %configure, etc) - Contains permisable code - %doc doesn't contain package critical files to operate - No header files or static / .so libs or pkgfiles - No gui so no need for .desktop files Please correct the buildrequires error so i can verify it builds cleanly in mock, once thats working i think we are done -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
