Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sysconftool - Macros for aclocal to install configuration files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177235 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gdk@xxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-01-13 11:04 EST ------- Two minor issues that you should resolve before building: - Development/Building is a non-standard Group setting. I know that Group is pretty worthless right now, but please try to keep to the Fedora Standards found here: http://fedoraproject.org/wiki/RPMGroups - The autotools that you're using (autoconf/automake) should be listed as BuildRequires. Also, you should consider using %{?dist} at the end of the Release, if you plan to build this for multiple branches (FC-3,FC-4,FC-5). See: http://fedoraproject.org/wiki/DistTag Review: - rpmlint checks return: W: sysconftool non-standard-group Development/Building (noted above) W: sysconftool symlink-should-be-relative /usr/bin/sysconftoolize /usr/share/sysconftool/sysconftoolize.pl W: sysconftool symlink-should-be-relative /usr/bin/sysconftoolcheck /usr/share/sysconftool/sysconftoolcheck Safe to ignore these symlinks. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - spec localized for en_US, pl, ok - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file This package is approved, with the caveat that you resolve the two minor issues before building. Also, I'll sponsor you based on this package (and your Aurora related work). Go ahead and do your paperwork. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
