Re: compiler bug turning up in cmake package?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



John Fine wrote:

> Ulrich Drepper wrote:
>> It's most certainly not that simple. I haven't looked at the sources.
>> But the asm code does not really correspond to the code above.  The
>> function above is most certainly inlined.  The problem might very well
>> (and most likely is) in the use of this function.  Look at the
>>
>>   cmELF::GetRPath()
>>
>> function and where it directly or indirectly uses the Valid function.
>>
>>   
> It is very simple and not a compiler bug, and you are correct that the
> error is in GetRPath.
> 
> The code is
> 
>   if(this->Valid() &&
>      this->Internal->GetFileType() == cmELF::FileTypeExecutable ||
>      this->Internal->GetFileType() == cmELF::FileTypeSharedLibrary)
> 
> Notice the lack of () around the || lines

So the simple(?) fix involves something like:
http://rdieter.fedorapeople.org/cmake-2.6.1-parens.patch
??

-- Rex


-- 
fedora-devel-list mailing list
fedora-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-devel-list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux