On Sat, 2008-08-09 at 00:36 +0300, Ville Skyttä wrote: > On Thursday 07 August 2008, David Malcolm wrote: > > On Thu, 2008-08-07 at 11:14 +0900, Mamoru Tasaka wrote: > > > > > > However the key "Encoding" is now deprecated and with Fedora 10 > > > desktop-file-utils (0.15-3.fc10) including Encoding key is warned like: > > > ------------------------------------------------------------------------- > > >- $ desktop-file-validate ./fedora-alexandria.desktop > > > ./fedora-alexandria.desktop: warning: key "Encoding" in group "Desktop > > > Entry" is deprecated > > > ------------------------------------------------------------------------- > > >-- > > > > Good point. The change of "Encoding" from being a required key to an > > optional key whose presence generates a warning suggests that all of the > > results in the db for this specific test (desktop-file-validate as > > reported by rpmlint) are meaningless. > > Hold on a bit. rpmlint should not output the invalid-desktop-file error > unless desktop-file-validate actually returns with a non-zero exit code. For > me it doesn't on F-9, everything appears to work as expected; see below. Ah, I was wrong, I was guessing that a warning made it a non-zero exit code. Thanks. > > Which version of rpmlint and desktop-file-validate are you running, and on > which distro? Currently there's a single host that's both the web server and doing the analysis work, and it's RHEL-5, not F9: rpmlint-0.83-1.el5 desktop-file-utils-0.10-7 It's clear that this approach isn't going to work, which I've filed as a bug against rpmgrok here: https://fedorahosted.org/rpmgrok/ticket/18 Looks like I need to fix that before the rpmlint side of rpmgrok would be useful. > > --- > > $ desktop-file-validate /usr/share/applications/mount-archive.desktop > /usr/share/applications/mount-archive.desktop: warning: key "Encoding" in > group "Desktop Entry" is deprecated > $ echo $? > 0 > > $ rpm -qf /usr/share/applications/mount-archive.desktop > gvfs-0.2.5-1.fc9.x86_64 > $ rpmlint gvfs > gvfs.x86_64: E: > sourced-script-with-shebang /etc/profile.d/gvfs-bash-completion.sh > gvfs.x86_64: E: > executable-sourced-script /etc/profile.d/gvfs-bash-completion.sh 0755 > gvfs.x86_64: W: > unused-direct-shlib-dependency /usr/lib64/libgvfscommon.so.0.0.0 /lib64/libgthread-2.0.so.0 > gvfs.x86_64: W: > unused-direct-shlib-dependency /usr/lib64/libgvfscommon.so.0.0.0 /lib64/librt.so.1 > gvfs.x86_64: W: > unused-direct-shlib-dependency /usr/lib64/libgvfscommon.so.0.0.0 /lib64/libgmodule-2.0.so.0 > gvfs.x86_64: W: > unused-direct-shlib-dependency /usr/lib64/libgvfscommon.so.0.0.0 /lib64/libdl.so.2 > gvfs.x86_64: W: > unused-direct-shlib-dependency /usr/lib64/libgvfscommon.so.0.0.0 /lib64/libutil.so.1 > 1 packages and 0 specfiles checked; 2 errors, 5 warnings. > > $ rpm -q desktop-file-utils rpmlint > desktop-file-utils-0.15-1.fc9.x86_64 > rpmlint-0.84-2.fc9.noarch Thanks for looking into this Dave -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list
