Patrice Dumas wrote:
On Thu, Mar 20, 2008 at 02:52:40PM +0100, Lubomir Kundrak wrote:
Hi all,
The second problem is not specifically FORTIFY_SOURCE related; you
should really include respective headers, many routines can really be
macros; such as open(). POSIX allows this iirc.
If you have more time, try to rebuild your package with
"-Werror-implicit-function-declaration" added to %optflags in your
~/.rpmmacros to see if you rely on implicit declarations where you
should include the header files with macros and/or prototypes instead.
There are about 200 of such functions in a package I maintain, the
cernlib. Is it really important to fix them? What are the implications?
Though the implicit declarations arer not for printf...
Yes fixing them is important, missing prototypes can lead to all sort of errors
and often lead to 64 bit issues (== crashes).
Maybe we should make -Werror-implicit-function-declaration part of the default
optflags?
Regards,
Hans
--
fedora-devel-list mailing list
fedora-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-devel-list
