On Mon, 2007-11-26 at 13:10 -0800, Eric Work wrote:
> 2. The other problem is that gtkdatabox is unable to build on x86_64 do
> to some problem with -fPIC even though it's being used when the source
> files are compile. I was able to compile the source on my 64-bit Ubuntu
> machine with no problems. Maybe a problem with autotools? The koji
> taskID is: 259807.
No, its a problem with the gtkdatabox source. Ubuntu might not have
caught it because G_GNUC_INTERNAL isn't defined in their toolchain (just
guessing). The gtk_databox_marshal_VOID__POINTER_POINTER has the
G_GNUC_INTERNAL attribute on it in the .h file, but not in the .c file,
thus the confusion at link time.
I've attached two patches, one to fix the x86_64 compile error, and the
other to make gtkdatabox use the Fedora optflags. And as a bonus, I've
attached a new spec file which not only applies these patches, it also
fixes the license tag to be in compliance with the Fedora licensing
policy.
But Wait! There's more!
...
Actually, no. That's it.
hth,
~spot
diff -up gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.h.BAD gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.h
diff -up gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.c.BAD gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.c
--- gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.c.BAD 2007-11-26 16:58:34.000000000 -0500
+++ gtkdatabox-0.8.0.1/gtk/gtkdatabox_marshal.c 2007-11-26 16:58:48.000000000 -0500
@@ -52,7 +52,7 @@
/* VOID:POINTER (gtkdatabox_marshal.list:2) */
/* VOID:POINTER,POINTER (gtkdatabox_marshal.list:3) */
-void
+G_GNUC_INTERNAL void
gtk_databox_marshal_VOID__POINTER_POINTER (GClosure * closure,
GValue * return_value,
guint n_param_values,
diff -up gtkdatabox-0.8.0.1/examples/Makefile.in.optflags gtkdatabox-0.8.0.1/examples/Makefile.in
--- gtkdatabox-0.8.0.1/examples/Makefile.in.optflags 2007-11-26 17:02:37.000000000 -0500
+++ gtkdatabox-0.8.0.1/examples/Makefile.in 2007-11-26 17:02:49.000000000 -0500
@@ -239,7 +239,7 @@ INCLUDES = \
-I$(top_srcdir)/gtk
AM_CFLAGS = \
- -O2\
+ $(RPM_OPT_FLAGS)\
-W -Wall -pedantic\
-DG_DISABLE_DEPRECATED\
-DGDK_DISABLE_DEPRECATED\
diff -up gtkdatabox-0.8.0.1/examples/Makefile.am.optflags gtkdatabox-0.8.0.1/examples/Makefile.am
--- gtkdatabox-0.8.0.1/examples/Makefile.am.optflags 2007-11-26 17:02:16.000000000 -0500
+++ gtkdatabox-0.8.0.1/examples/Makefile.am 2007-11-26 17:02:27.000000000 -0500
@@ -37,7 +37,7 @@ INCLUDES = \
-I$(top_srcdir)/gtk
AM_CFLAGS =\
- -O2\
+ $(RPM_OPT_FLAGS)\
-W -Wall -pedantic\
-DG_DISABLE_DEPRECATED\
-DGDK_DISABLE_DEPRECATED\
diff -up gtkdatabox-0.8.0.1/gtk/Makefile.in.optflags gtkdatabox-0.8.0.1/gtk/Makefile.in
--- gtkdatabox-0.8.0.1/gtk/Makefile.in.optflags 2007-11-26 06:15:38.000000000 -0500
+++ gtkdatabox-0.8.0.1/gtk/Makefile.in 2007-11-26 17:01:17.000000000 -0500
@@ -234,7 +234,7 @@ INCLUDES = \
-I$(top_srcdir)
AM_CFLAGS = \
- -O2\
+ $(RPM_OPT_FLAGS)\
-W -Wall -pedantic\
-DG_DISABLE_DEPRECATED\
-DGDK_DISABLE_DEPRECATED\
diff -up gtkdatabox-0.8.0.1/gtk/Makefile.am.optflags gtkdatabox-0.8.0.1/gtk/Makefile.am
--- gtkdatabox-0.8.0.1/gtk/Makefile.am.optflags 2007-11-21 17:25:44.000000000 -0500
+++ gtkdatabox-0.8.0.1/gtk/Makefile.am 2007-11-26 17:01:17.000000000 -0500
@@ -48,7 +48,7 @@ INCLUDES = \
-I$(top_srcdir)
AM_CFLAGS =\
- -O2\
+ $(RPM_OPT_FLAGS)\
-W -Wall -pedantic\
-DG_DISABLE_DEPRECATED\
-DGDK_DISABLE_DEPRECATED\
Name: gtkdatabox
Version: 0.8.0.1
Release: 1%{?dist}
Summary: GTK+ widget for fast data display
Group: System Environment/Libraries
License: LGPLv2+
URL: http://www.eudoxos.net/gtk/gtkdatabox
Source: http://www.eudoxos.net/gtk/gtkdatabox/download/%{name}-%{version}.tar.gz
Patch0: gtkdatabox-0.8.0.1-userpmoptflags.patch
Patch1: gtkdatabox-0.8.0.1-compilefix.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: gtk2-devel, pkgconfig
%description
GtkDatabox is a widget for the GTK+ library designed to display
large amounts of numerical data fast and easy.
%package devel
Summary: Development files for %{name}
Group: Development/Libraries
Requires: %{name} = %{version}-%{release}
Requires: gtk2-devel, pkgconfig
%description devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.
%prep
%setup -q
%patch0 -p1 -b .optflags
%patch1 -p1 -b .compilefix
%build
%configure --disable-static
make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
%clean
rm -rf $RPM_BUILD_ROOT
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
%files
%defattr(-,root,root,-)
%doc AUTHORS ChangeLog COPYING NEWS README TODO
%{_libdir}/libgtkdatabox-*.so.*
%files devel
%defattr(-,root,root,-)
%doc examples/*.c
%{_includedir}/gtkdatabox*.h
%{_libdir}/libgtkdatabox.so
%{_libdir}/pkgconfig/gtkdatabox.pc
%changelog
* Mon Nov 26 2007 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 0.8.0.1-2
- fix license tag
- use rpm optflags
* Mon Nov 26 2007 Eric Work <work.eric@xxxxxxxxx> 0.8.0.1-1
- new upstream version
* Tue Mar 20 2007 Eric Work <work.eric@xxxxxxxxx> 0.7.0.1-1
- new upstream version
* Sat Nov 11 2006 Eric Work <work.eric@xxxxxxxxx> 0.7.0.0-4
- bumped EVR to assure devel replaces FC6
* Fri Sep 15 2006 Eric Work <work.eric@xxxxxxxxx> 0.7.0.0-3
- bumped version to prepare for FC6
* Thu Aug 17 2006 Eric Work <work.eric@xxxxxxxxx> 0.7.0.0-2
- removed devel post/postun scripts
* Fri Aug 11 2006 Eric Work <work.eric@xxxxxxxxx> 0.7.0.0-1
- updated to 0.7.0.0
* Tue Aug 08 2006 Eric Work <work.eric@xxxxxxxxx> 0.6.0.0-1
- updated to 0.6.0.0
* Fri Jun 23 2006 Eric Work <work.eric@xxxxxxxxx> 0.5.3.0-1
- initial release
--
fedora-devel-list mailing list
fedora-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-devel-list
