Re: LSB init scripts and NETWORKING=no && exit 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ville Skyttä (ville.skytta@xxxxxx) said: 
> One more question related to LSB init scripts:
> 
> A commonly found current approach in init scripts for services that require 
> networking to be up is:
> 
>     # Source networking configuration.
>     . /etc/sysconfig/network
>     # Check that networking is up.
>     [ "$NETWORKING" = "no" ] && exit 0
> 
> Silently exiting with 0 no matter which action was requested does not look 
> like something expected of LSB compliant init scripts.
> 
> Actually, all of 1) silent exit and 2) the zero exit value and 3) the way "is 
> networking up?" is checked seem questionable to me.  Anyone have ideas for 
> better approaches to this?

NETWORKING=no means 'networking has never been configured on this box'. Frankly,
I'd nuke the whole section - it's rather pointless, and will not be set on
any normal machine.

(The comment is misleading.)

Bill

-- 
fedora-devel-list mailing list
fedora-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-devel-list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux