On 24/2/25 11:07, Jian Peng wrote:
Dear Fedora Development Team,
I hope this email finds you well.
I have submitted a bug report on Fedora's Bugzilla regarding an issue
with the Aide project (ID: 2346091
<https://bugzilla.redhat.com/show_bug.cgi?id=2346091>), which involves
a patch fix and modification for the project.
As I have not received a response yet, I would like to follow up
through this mailing list. I am seeking further assistance or guidance
regarding the progress of the patch and the steps for handling it.
If replying to Bugzilla is not convenient for you, I’ll briefly
summarize the issue here:
What is it you are asking to be done?
It's easy enough to verify the patch gets applied and it is a revert.
The package builds fine as it is.
So I don't know what you are asking.
Ian
``` diff -up ./src/conf_eval.c.fix ./src/conf_eval.c ---
./src/conf_eval.c.fix 2023-12-22 12:12:22.961141634 +0100 +++
./src/conf_eval.c 2023-12-22 14:09:21.217786675 +0100 @@ -166,6 +166,7
@@ static DB_ATTR_TYPE eval_attribute_expre static void
set_database_attr_option(DB_ATTR_TYPE attr, int linenumber, char
*filename, char* linebuf) { char *str; + long num;
DB_ATTR_TYPE hashes = get_hashes(true); if
(attr&(~hashes)) { @@ -298,8 +299,20 @@ static void
eval_config_statement(config
LOG_CONFIG_FORMAT_LINE(LOG_LEVEL_CONFIG, "set 'config_version' option
to '%s'", str) break; case VERBOSE_OPTION: -
log_msg(LOG_LEVEL_ERROR, "%s:%d: 'verbose' option is no longer
supported, use 'log_level' and 'report_level' options instead (see man
aide.conf for details) (line: '%s')", conf_filename, conf_linenumber,
conf_linebuf); - exit(INVALID_CONFIGURELINE_ERROR); +
log_msg(LOG_LEVEL_CONFIG, "%s:%d: 'verbose' option is deprecated,
use 'log_level' and 'report_level' options instead (see man aide.conf
for details) (line: '%s')", conf_filename, conf_linenumber,
conf_linebuf); + str = eval_string_expression(statement.e,
linenumber, filename, linebuf); + num = strtol(str, NULL,
10); + + if (num < 0 && num > 255) { +
LOG_CONFIG_FORMAT_LINE(LOG_LEVEL_ERROR, "invalid verbose level:
'%s'", str); + exit(INVALID_CONFIGURELINE_ERROR); +
} + + if (num >= 10) { +
set_log_level(LOG_LEVEL_DEBUG); + } + +
free(str); break; case LIMIT_CMDLINE_OPTION:
/* command-line options are ignored here */ ```
The patch 'aide-verbose.patch' contains a scoping issue with the `num`
variable, which is defined in one function
(`set_database_attr_option`) but used in another
(`eval_config_statement`), causing a compilation error. Additionally,
the condition `if (num < 0 && num > 255)` is logically incorrect as
`num` cannot simultaneously be less than 0 and greater than 255.
Thank you for your time and attention. Looking forward to your response.
Thank you!
penny
Student
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
