Re: bin/sbin merge: Are we going to change kconfig MODPROBE_PATH?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 05, 2025 at 12:03:21PM +0000, Richard W.M. Jones wrote:
> https://github.com/torvalds/linux/blob/5c8c229261f14159b54b9a32f12e5fa89d88b905/kernel/module/Kconfig#L416
> 
> This defaults to "/sbin/modprobe".  Should it be changed to
> "/usr/bin/modprobe"?
> 
> A few possible reasons:
> 
> (1) Bad RPM installers that don't run scripts, specifically the
> filesystem.spec script.  (This is the case that broke for me.)

Can you expand a bit on this? All installs with 'rpm' should DTRT.

> (2) I suspect some race between needing to modprobe modules are
> running the filesystem.spec script, even in a well-behaved RPM
> install.

Indeed, there is a race on split systems, during the first upgrade
from a package with /usr/sbin/modprobe to a package with /usr/bin/modprobe.
The window is between the %postun phase of the old package and
the %posttrans scriptlets in filesystem to create the symlink.
But I think this can be ignored… It's a one-time occurence and
would require new drivers to requested in in that window.

In general, when stuff is in the middle of the upgrade, some minor
transitory issues are expected. It's very hard to make those completely
go away with our non-transactional system and that's why we officially
recommend offline upgrades.

> (3) Extremely small speed increase not having to follow a symlink?

The downside of changing the path is that systems with the old path
would stop working. It's impossible to ensure the version of the
userspace from the kernel. Because of that, I'd vote against changing
the path as split systems are supported (i.e. at least until F41 goes
EOL).

Zbyszek
-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux