On 2/4/25 11:22 AM, Zbigniew Jędrzejewski-Szmek wrote:
> On Tue, Feb 04, 2025 at 09:45:19AM -0500, William Cohen wrote:
>>>> +%global layout _opt
>>>> +Release: 1%{?dist}%{?layout}
>>> In various places the patch does such indirections… Please kill them, they
>>> make the diff much more verbose and actually harder to follow.
>>>
>>> → Release: 1%{?dist}%{?_with_opt:_opt}
>>>
>>> Same for %{call_graph} as alias for %SOURCE12.
>>
>> The problem being addressed with the %SOURCEnn and %call_graph was that the call graph needs to be stored in srpm rpm. Those files need to be %sourcenn in the spec file, just defining %call_graph as the callgraph file is not going to pull the call graph file into the source rpm. Having the definition of %{call_graph} is to allow the later boilerplate code to be same between various spec files.
>
> Yes, you need the file to be listed as Source.
> My suggestion is to use %SOURCEnn in the "later boilerplate"
> (with the number appropriately selected, e.g. the first unused).
> This is nicer for the packager, 'cause the packager doesn't care
> about the boilerplate being the same between various spec files.
> They care about their single spec file being uncomplicated.
>
> Zbyszek
>
The %{call_graph} alias isn't complicating the spec file. The %{call_graph} as alias for the source file makes it easier to understand the purpose of the file. Overtime the source file might be changed. Having the alias right by the source file localizes any changes that need to be made. The alias will help people porting this functionality to other spec files as there are fewer scattered locations to customize for the specific packages.
-Will
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
