On Tue, Feb 04, 2025 at 02:54:30PM +0000, Sérgio Basto via devel wrote:
> Hi,
> In this case: "packages which install to hardcoded $DESTDIR/usr/sbin,
> but then use %{_sbindir} in %files, will need to be adjusted."
>
> I did this [1] after the make install, is that correct ?
>
> [1]
> %if "%{_sbindir}" == "%{_bindir}"
> mkdir -p %{buildroot}%{_bindir}
> mv %{buildroot}/usr/sbin/* %{buildroot}%{_bindir}
> %endif
There are different levels of "correct", at your discretion IMHO.
Ideally the app would be honouring the '--sbindir=XXX' arg to configure.
Give your comment though, I assume it does not do that.
My first inclination would be to patch the Makefile.am to make it honour
--sbindir, by using @sbindir@ & re-run autoconf/automake. This would be
a patch that is suitable to submit back to upstream, and hopefully then
you can drop the patch on the next upstream release.
While you're waiting for upstream though, or if you don't want to touch
patches to Makefiles, then your approach of moving stuff after the fact
is not unreasonable.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
