Re: Inadvertent mass-rebuild triggered soname bump in libnfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-01-24 at 02:41 +0000, Richard W.M. Jones wrote:
> On Wed, Jan 22, 2025 at 05:07:45PM -0800, Adam Williamson wrote:
> > Much like libtest, the mass rebuild has inadvertently bumped the soname
> > of libnfs. libnfs 6 was in dist-git but had never been built for
> > Rawhide (there were some attempts in side tags, but they all seem to
> > have been garbage collected). The mass rebuild built it, so now libnfs
> > has gone from 5.x to 6.x and soname libnfs.so.14 to libnfs.so.16. This
> > actually does include a major API change, see upstream:
> > 
> > https://github.com/sahlberg/libnfs/commit/5e8f7ce273308eb77f94248f4501e574a703c1a5
> > 
> > there are four external deps of libnfs that I can see:
> > 
> > gvfs-nfs-0:1.56.1-1.fc42.x86_64
> > qemu-block-nfs-2:9.2.0-3.fc42.x86_64
> > vlc-plugins-extra-1:3.0.21-15.fc42.x86_64
> > xine-lib-0:1.2.13-17.fc42.x86_64
> > 
> > qemu-block-nfs and gvfs-nfs are the most important there. qemu-block-
> > nfs not being installable is breaking at least one other build I'm
> > trying to do.
> 
> FWIW this was discussed on the qemu list a little while back:
> https://lists.nongnu.org/archive/html/qemu-block/2024-12/msg00151.html

Yeah, I filed a bug referencing it:
https://bugzilla.redhat.com/show_bug.cgi?id=2341787

> There's no upstream patch yet, but there's a possible patch in that
> thread.  Part of the problem is if we (upstream) want to retain
> compatibility with libnfs < 6, as the API for the function we're using
> changed quite significantly.

The other projects all kept compatibility too and all did it with
ifdefs.

vlc: https://code.videolan.org/videolan/vlc/-/merge_requests/6527
gvfs: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/257
xine-lib:
https://src.fedoraproject.org/rpms/xine-lib/blob/rawhide/f/xine-lib-1.2.13-fix_libnfs6.patch

As you can see, libnfs provides a specific macro to use for this,
LIBNFS_API_V2 .
-- 
Adam Williamson (he/him/his)
Fedora QA
Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@xxxxxxxxxxxxx
https://www.happyassassin.net




-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux