Re: F42 Change Proposal: Replace SDL 2 with sdl2-compat using SDL 3 (self-contained)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 18, 2025 at 9:49 PM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
>
> On Sat, Jan 18, 2025 at 9:36 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote:
> >
> > On Tue, 2024-12-03 at 18:21 +0000, Aoife Moloney via devel-announce
> > wrote:
> > > Wiki - https://fedoraproject.org/wiki/Changes/SDL2onSDL3
> > > Discussion Thread -
> > > https://discussion.fedoraproject.org/t/f42-change-proposal-replace-sdl-2-with-sdl2-compat-using-sdl-3-self-contained/138987
> > >
> > > This is a proposed Change for Fedora Linux.
> > > This document represents a proposed Change. As part of the Changes
> > > process, proposals are publicly announced in order to receive
> > > community feedback. This proposal will only be implemented if
> > > approved
> > > by the Fedora Engineering Steering Committee.
> > >
> > > == Summary ==
> > > This Change proposes to replace SDL 2 with sdl2-compat, which uses
> > > SDL 3.
> > >
> > > == Owner ==
> > >
> > > * Name: [[User:Ngompa| Neal Gompa]]
> > > * Email: ngompa13@xxxxxxxxx
> > >
> > >
> > > == Detailed Description ==
> > > SDL 2 feature development ended some time ago with efforts being
> > > focused on SDL 3. However, many older games still use SDL 2 and
> > > cannot
> > > change to SDL 3. In order to continue to support SDL 2 games in the
> > > modern world, let's replace SDL 2 with sdl2-compat, which uses SDL 3.
> > > This also has the effect of moving SDL 1.2 games to SDL3 through
> > > sdl12-compat running on sdl2-compat.
> > >
> > >
> > > == Feedback ==
> > >
> > >
> > > == Benefit to Fedora ==
> > > Switching SDL 2 powered games to use <code>sdl2-compat</code> ensures
> > > that SDL-based applications continue to use the actively developed
> > > codebase. This also has the effect of SDL 1.2 powered games that use
> > > <code>sdl12-compat</code> to run on SDL3 as well through the fully
> > > supported path of <code>sdl12-compat</code> running on
> > > <code>sdl2-compat</code> running on SDL3.
> > >
> > > == Scope ==
> > > * Proposal owners:
> > > ** Package [https://github.com/libsdl-org/sdl2-compat libsdl2-compat]
> > > (native: [https://bugzilla.redhat.com/2316576 RH#2316576], mingw:
> > > [https://bugzilla.redhat.com/2330101 RH#2330101])
> > > ** Retire {{package|SDL2}} and {{package|mingw-SDL2}} completely
> > >
> > > * Other developers:
> > >
> > > * Release engineering: [https://pagure.io/releng/issue/12485 #12485]
> > >
> > > * Policies and guidelines: N/A (not needed for this Change)
> > >
> > > * Trademark approval: N/A (not needed for this Change)
> > >
> > >
> > > * Alignment with the Fedora Strategy: N/A
> > >
> > > == Upgrade/compatibility impact ==
> > > The <code>SDL2</code> package would be transparently upgraded to
> > > <code>libsdl2-compat</code> package and games using it should just
> > > transparently start using SDL 3.0.
> > >
> > >
> > > == How To Test ==
> > > The testing steps are simple:
> > >
> > > 0. Enable the
> > > [https://copr.fedorainfracloud.org/coprs/ngompa/SDL2onSDL3/
> > > <code>SDL2onSDL3</code> COPR]: <code>dnf copr enable
> > > ngompa/SDL2onSDL3</code>
> > >
> > > 1. Swap <code>SDL2</code> for <code>sdl2-compat</code>: <code>dnf
> > > swap
> > > SDL2 sdl2-compat</code>
> >
> > From results of https://koschei.fedoraproject.org/package/mlt , I guess
> > mlt started to fail to build since this change .
> >
> > mlt builds with module for SDL1 and module for SDL2, so [1] is correct
> > ?  what devel packages should we use to build with SDL packages ? and
> > SDL2_image-devel could be along SDL3-devel  ?
> >
> > Regards,
> >
> > [1]
> >  BuildRequires:  SDL-devel
> >  BuildRequires:  SDL_image-devel
> >
> >  %if 0%{?fedora} >= 42
> >  BuildRequires:  SDL3-devel
> >  %else
> >  BuildRequires:  SDL2-devel
> >  BuildRequires:  SDL2_image-devel
> >  %endif
> >
>
> Unless MLT has ported to SDL3 directly, no change needs to be made.
>

Also, the current failures are caused by the GCC transition:

/builddir/build/BUILD/mlt-7.28.0-build/mlt-7.28.0/src/modules/sdl2/common.c:40:17:
error: implicit declaration of function ‘strcmp’
[-Wimplicit-function-declaration]
   40 |             if (strcmp(driver, "disk") == 0 || strcmp(driver,
"dummy") == 0) {
      |                 ^~~~~~
/builddir/build/BUILD/mlt-7.28.0-build/mlt-7.28.0/src/modules/sdl2/common.c:23:1:
note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
   22 | #include <framework/mlt_log.h>
  +++ |+#include <string.h>
   23 |

It's just missing headers.



-- 
真実はいつも一つ!/ Always, there's only one truth!
-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux