On Thu, Dec 05, 2024 at 03:45:59PM +0100, Miro Hrončok wrote: > What is the blocker to run this in Koji/mock? > > You do `make_sediment_rpmmacros > ~/.rpmmacros`. > > What's the issue with %defining such macros at spec level? I don't think the approach with 'make_sediment_rpmmacros' can work. It attempts to extend %build_clags and %build_ldflags, but it evaluates those flags in some environment which might be different than the rpmbuild environment. For example, if %name is defined, we also get -specs=/usr/lib/rpm/redhat/redhat-package-notes in %build_ldflags. make_sediment_rpmmacros sets %build_ldflags that doesn't have that. I think it's better to just let users explictly call some macro at the beggining of %build that'll handle modifying CLFAGS/LDFLAGS/… and call gv2link. This would be clearer and should work in local builds, mock, and koji. Zbyszek -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
