Hi,
On Mon, 2024-12-02 at 14:14 +0000, Martin Gansser wrote:
> with this patch, it compiles:
>
> --- CPU-X-5.1.1/data/CMakeLists.txt.orig 2024-12-02
> 14:00:01.633120597 +0100
> +++ CPU-X-5.1.1/data/CMakeLists.txt 2024-12-02
> 14:01:24.046247681 +0100
> @@ -36,11 +36,11 @@
> DESTINATION
> ${CMAKE_INSTALL_FULL_DATADIR}/applications/
> )
>
> - # Install policy rule
> + # Install policy rule
> pkg_get_variable(POLKIT_ACTION_DIR polkit-gobject-1
> actiondir)
> - if(${POLKIT_ACTION_DIR} STREQUAL "")
> + if (NOT POLKIT_ACTION_DIR OR POLKIT_ACTION_DIR STREQUAL "")
> set(POLKIT_ACTION_DIR
> "${CMAKE_INSTALL_FULL_DATADIR}/polkit-1/actions/")
You're just patching over a symptom here, not the cause. Instead of
this, you should add BuildRequires: pkgconfig(polkit-gobject-1) . (The
pkg_get_variable() line is supposed to get the actiondir variable from
polkit-gobject-1.pc and assign it to POLKIT_ACTION_DIR. Obviously it
cannot do that if polkit-gobject-1.pc is not present.)
D.
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
