One of the issues discovered during the latest ELN mass rebuild is that
the `%ctest -- -E ...` or `%ctest -- -V` syntax is no longer accepted,
instead resulting in an error, e.g.:
+ /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure
--force-new-ctest-process -j12 -- -E valgrind
CMake Error: Unknown argument: --
CMake Error: Run 'ctest --help' for all supported options.
IIUC this syntax was originally adopted to allow passing short options
to the ctest binary, as the %ctest macro was originally defined with
(:-:), but it was eventually changed to accept valid short arguments:
https://bugzilla.redhat.com/show_bug.cgi?id=2127650
https://src.fedoraproject.org/rpms/cmake/c/198fb99c989b7ff62ce3320610989143fba65b76
With that, it should be possible to simply omit the '--', but it seems
at least some such use cases were never updated.
Since the %ctest macro does not handle the '--', it gets passed straight
to the ctest binary. While this was never valid, prior to cmake 3.30
this seems to have been ignored, but not anymore, AFAICS due to:
https://gitlab.kitware.com/cmake/cmake/-/commit/304396d13c5ae84ddbf60c5d2979f9461a26c7bf
Note that all current Fedora branches now have cmake 3.30.5, as does
c10s (for EPEL 10).
Potentially affected packages (clamav and proj are definite):
clamav.spec: %ctest3 -- -E valgrind || :
clamav.spec: %ctest3 -- -E valgrind
clamav.spec: %ctest3 -- -R valgrind || :
colorized-logs.spec: %ctest -- --output-on-failure
combblas.spec: %ctest -- %{debug_flags} --test-dir build/openmpi -E
'Indexing_Test|SpAsgn_Test|FBFS_Test|FMIS_Test|BPMM_Test'
combblas.spec: %ctest -- %{debug_flags} --test-dir build/mpich -E
'Indexing_Test|SpAsgn_Test|FBFS_Test|FMIS_Test|BPMM_Test'
folly.spec: %ctest -- ${EXCLUDED_TESTS}
glm.spec: %ctest -- --output-on-failure -E 'test-gtc_packing'
google-cpu_features.spec: %ctest -- -VV
metis.spec: %ctest -- --test-dir ./
metis.spec: %ctest -- --test-dir ./
nativejit.spec: %ctest -- -VV
openmeeg.spec: %ctest -- -VV --force-new-ctest-process -j1
--output-on-failure --debug -E 'openmeeg_python_test_python2.py'
openmeeg.spec: %ctest -- -E 'openmeeg_python_test_python2.py'
proj.spec: %ctest -- -E nkg
sdsl-lite.spec: %ctest -- -E 'k2-treap-test_k2-0.1.0.0'
sundials.spec: %ctest -- -VV --output-on-failure --debug
sundials.spec: %ctest -- --output-on-failure -E
'test_sunlinsol_superlumt|test_fsunlinsol_dense_mod'
sundials.spec: %ctest -- -VV --output-on-failure --debug
sundials.spec: %ctest -- --output-on-failure -E
'test_sunlinsol_superlumt|test_fsunlinsol_dense_mod'
sundials.spec: %ctest -- -VV --output-on-failure --debug
sundials.spec: %ctest -- --output-on-failure -E
'test_sunlinsol_superlumt|test_fsunlinsol_dense_mod'
superlu_dist.spec: %ctest -- --test-dir build/openmpi -VV
superlu_dist.spec: %ctest -- --test-dir build/mpich -VV
weechat.spec: %ctest3 -- -V
xrootd.spec: %ctest -- -E $exclude
--
Yaakov Selkowitz
Principal Software Engineer, Emerging RHEL
Red Hat, Inc.
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
