On Thu, 2024-11-28 at 09:26 +0000, Peter Robinson wrote: > On Thu, 28 Nov 2024 at 09:23, Adam Williamson > <adamwill@xxxxxxxxxxxxxxxxx> wrote: > > > > Hey folks! just wanted to alert you to an, ahem, situation today... > > > > I foolishly fiddled with the production greenwave config (I forgot > > staging greenwave was a thing...) and got burned. For a few minutes I > > pushed a bad config that disabled gating entirely, and since Bodhi > > checks whether Rawhide updates are ready to be pushed every two > > minutes, it cheerfully went right ahead and pushed every Rawhide update > > which was previously gated. > > Is that not the reason there's pull request and review for changes > before they're deployed? Yes, but because of Thanksgiving, nobody was around. I doubt this would've been found on review, anyway, because it involves jinja block newline handling, which is basically black magic, especially when mixed with ansible. Turns out something in that mix transparently enables the jinja feature called trim_blocks, which completely changes how they work. If you test the same template I wrote just by providing all the necessary variables and running `jinja2` on it, you get completely different output, so if I or anyone else had tested it that way, we would not have seen the problem that happened. Now I know about that I know how to test a template with trim_blocks, but I wouldn't have figured that out ahead of time. Of course, maybe somebody else already knew this :| What I really needed was to wait for someone to say hey, we should merge this then run it on staging first to see what happens :| Sorry about that. -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@xxxxxxxxxxxxx https://www.happyassassin.net -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
