Hi Yaakov,
I was looking to update rust-zram-generator and I noticed the following:
commit 820c5ec20c000e2f0ef57d19970311901d598cf1
Author: Yaakov Selkowitz <yselkowi@xxxxxxxxxx>
Date: Mon May 15 20:13:52 2023 -0400
Use vendored dependency in RHEL builds
This introduces and rpm macro logic bug which causes the vendored dependencies
to be unpacked unconditionally. I guess that most likely the same pattern was
used in other packages. IIUC, the unpacked vendor/ dir is actually not used for
anything. But it seems wasteful and confusing to unpack the second sources.
It'd be nice to fix this everywhere the same pattern was used.
The problem is this:
%autosetup -n %{crate}-%{version_no_tilde} -p1 %{?bundled_rust_deps:-a2}
%{?bundled_rust_deps:…} effectively checks if %bundled_rust_deps is defined.
It always is, to either 0 or 1.
Zbyszek
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
