On Tue, Oct 22, 2024 at 10:24:58AM -0700, Adam Williamson wrote: > On Tue, 2024-10-22 at 16:11 +0100, Richard W.M. Jones wrote: > > [So no one else ends up waiting around like an idiot] > > > > Koji 1.35 changed how repositories and side tags and such get rebuilt, > > so they no longer get rebuilt on their own. Instead you have to *either*: > > > > fedpkg build --target=... --wait-build=<build> > > > > *or*: > > > > koji wait-repo <tag> --build=<build> --request > > > > where the --request option (I think implied in the first command) will > > both request that the repository is recreated and wait for it. Yeah, if you want to be sure. If your side tag is against say rawhide, just doing a build on it later will likely get a newrepo anyhow as the base tag has updated since, but the above are some ways to be sure. Note also, that when you make a sidetag if you wait for the newrepo for that to finish it works as before (creating a side tag creates a newrepo for it right away). Also, chain build should work as before and do the right thing. This has been a massive win I think... before we were doing vast piles of pointless newrepos and taking up cpu and disk space, and now it's so much quieter and nicer. https://docs.pagure.org/koji/repo_generation/ is the upstream doc if folks want to read more. > > Rich. > > Hmm. I think some code and docs may need to be updated for this. > > Bodhi has bodhi.client.cli._generate_wait_repo_command , which produces > a command of the format `koji wait-repo <tag> --build=<build>` - no `-- > request` - which it uses to print a hint when you create a buildroot > override, and which it actually runs if you pass --wait when creating a > buildroot override. Yeah, that will need updating. I do again wonder if we need to keep overrides in place anymore. I guess we talked about getting everyone to use sidetags, but there were some corner cases? I can't recall... > fedpkg - via rpkg - prints a hint "Use 'koji wait-repo f41-build-side- > 7863' to wait for the build repo to be generated." when you create a > side tag. The code for that is in rpkg, pyrpkg/cli.py . The Package That should still work. sidetags do make a initial newrepo when they are created. > Update Guide doc - > https://docs.fedoraproject.org/en-US/package-maintainers/Package_Update_Guide/#multiple_packages > - shows a sample `fedpkg request-side-tag` command which includes this > output, and then says "The latter is important if any builds depend on > previous ones in the side tag. Use `koji wait-repo --build <package- > nvr> <side-tag>` to ensure that the respective build is available in > the build root for subsequent builds." Yes, that should be fixed to either --request, or add the --wait-build to the next build invocation. > Do we need to update some or all of those? If so, who wants to do it? > :) Yeah, we should... someone should. ;) kevin
Attachment:
signature.asc
Description: PGP signature
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
