On Mon, 2024-08-26 at 07:40 +0000, Martin Gansser wrote: > I am trying to build pyliblo3 from your repo on Fedora 41 with python 3.13.0. > I've got a build error during compilation: > > # wget https://github.com/gesellkammer/pyliblo3/archive/refs/heads/master.zip > # unzip pyliblo3-master.zip; cd pyliblo3-master; ./setup build > > root@fc41:/tmp/pyliblo3-master# ./setup.py build > running build > running build_py > creating build > creating build/lib.linux-x86_64-cpython-313 > creating build/lib.linux-x86_64-cpython-313/pyliblo3 > copying pyliblo3/__init__.py -> build/lib.linux-x86_64-cpython-313/pyliblo3 > copying pyliblo3/_liblo.pyi -> build/lib.linux-x86_64-cpython-313/pyliblo3 > running build_ext > Compiling pyliblo3/_liblo.pyx because it changed. > [1/1] Cythonizing pyliblo3/_liblo.pyx > /usr/lib64/python3.13/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /tmp/pyliblo3-master/pyliblo3/_liblo.pxd > tree = Parsing.p_module(s, pxd, full_module_name) > building 'pyliblo3._liblo' extension > creating build/temp.linux-x86_64-cpython-313 > creating build/temp.linux-x86_64-cpython-313/pyliblo3 > gcc -fno-strict-overflow -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -fcf-protection -fexceptions -fcf-protection -fexceptions -fcf-protection -fexceptions -O3 -fPIC -Ipyliblo3 -I/usr/include -I/usr/local/include -I/usr/include/python3.13 -c pyliblo3/_liblo.c -o build/temp.linux-x86_64-cpython-313/pyliblo3/_liblo.o -fno-strict-aliasing -Werror-implicit-function-declaration -Wfatal-errors > pyliblo3/_liblo.c: In function ‘__pyx_f_8pyliblo3_6_liblo__msg_callback’: > pyliblo3/_liblo.c:9011:92: error: passing argument 1 of ‘lo_blob_dataptr’ from incompatible pointer type [-Wincompatible-pointer-types] > 9011 | __pyx_t_7 = __Pyx_PyBytes_FromCString(((unsigned char *)lo_blob_dataptr((__pyx_v_argv[__pyx_v_i])))); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 274, __pyx_L1_error) > | ~~~~~~~~~~~~~^~~~~~~~~~~~ > | | > | lo_arg * > pyliblo3/_liblo.c:1353:78: note: in definition of macro ‘__Pyx_PyBytes_FromCString’ > 1353 | #define __Pyx_PyBytes_FromCString(s) __Pyx_PyBytes_FromString((const char*)s) > | ^ > compilation terminated due to -Wfatal-errors. > error: command '/usr/bin/gcc' failed with exit code 1 > > if i edit pyliblo3-master/pyliblo3/_liblo.c > and change the line 9011 to: > __pyx_t_7 = __Pyx_PyBytes_FromCString((unsigned char *)lo_blob_dataptr(*(struct lo_blob_ **)&__pyx_v_argv[__pyx_v_i])); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 274, __pyx_L1_error) > > pyliblo3 compiles with ./setup build. > but how can I patch this file permanently ? I'm a bit confused who you're directing this to. Who is the "you" in "your repo"? You seem to be the person who submitted the review request for this package: https://bugzilla.redhat.com/show_bug.cgi?id=2307912 If you want to maintain a package, you should probably know how to generate and include patches, it's a basic skill for package maintenance. There is a guide at https://rpm-packaging-guide.github.io/#patching-software , although for software maintained in git, I would usually do it by checking out upstream git, committing the change to my local checkout, then using git format-patch to produce a patch file and copying it to the package directory. Miro already posted a patch for this issue in the FTBFS bug for pyliblo: https://bugzilla.redhat.com/show_bug.cgi?id=2248131#c5 -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@xxxxxxxxxxxxx https://www.happyassassin.net -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
