On 2/21/24 11:46 AM, Jakub Jelinek wrote:
On Wed, Feb 21, 2024 at 11:34:37AM -0500, Steven A. Falco wrote:
I am getting an error "template-id not allowed for constructor in C++20" but according to the Copr log [0], the compiler is being given -std=c++17:
It is a warning, but you've asked for all warnings to be errors, right?
As documented
https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-Wtemplate-id-cdtor
the warning is enabled by default when compiling with -std=c++20 or newer,
or when -Wc++20-compat warning is enabled, and the latter as documented
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wc_002b_002b20-compat
is enabled by default in -Wall, which you asked for.
The purpose of the warning is to warn that this won't be accepted in C++20
anymore and there is no reason not to make it valid C++20 right away by
removing the redundant part.
Thanks! I'll work with the upstream folks to see how they want to handle it.
Steve
Building CXX object thirdparty/clipper2/CMakeFiles/clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.o
cd /builddir/build/BUILD/kicad-7.0.11/redhat-linux-build/thirdparty/clipper2 && /usr/bin/g++ -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SIGNAL_INTEGRITY -DKICAD_SPICE -DUSINGZ -DWXUSINGDLL -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -I/builddir/build/BUILD/kicad-7.0.11/thirdparty/clipper2/Clipper2Lib/include -isystem /builddir/build/BUILD/kicad-7.0.11/thirdparty/pybind11/include -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/opencascade -isystem /usr/lib64/wx/include/gtk3-unicode-3.2 -isystem /usr/include/wx-3.2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wno-attributes -pthread -O2 -g -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wpedantic -Werror -MD -MT thirdparty/clipper2/CMakeFiles/clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.o -MF CMakeFiles/clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.o.d -o CMakeFiles/clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.o -c /builddir/build/BUILD/kicad-7.0.11/thirdparty/clipper2/Clipper2Lib/src/clipper.engine.cpp
In file included from /builddir/build/BUILD/kicad-7.0.11/thirdparty/clipper2/Clipper2Lib/include/clipper2/clipper.engine.h:22,
from /builddir/build/BUILD/kicad-7.0.11/thirdparty/clipper2/Clipper2Lib/src/clipper.engine.cpp:17:
/builddir/build/BUILD/kicad-7.0.11/thirdparty/clipper2/Clipper2Lib/include/clipper2/clipper.core.h:139:22: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
139 | explicit Point<T>(const Point<T2>& p)
Jakub
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue