Hello, Patrice! On Monday, 19 February 2024 at 13:55, Patrice Peterson via devel wrote: > Hello to all and sundry! > > I've been a Fedora user for close to ten years but I've never been involved > with the project itself, aside from reporting a few bugs here and there. > Been using Linux for ~20 years, more or less – started out on Ubuntu, moved > over to Arch, and then Fedora. On Arch, I used to maintain a few AUR > packages, mostly games. A while ago, I began getting into music production > on Linux, started building flatpaks and submitting my first one to Flathub > [1], and I'm currently trying to pull the rtirq package into the current > decade [2]. Some quick nitpicks for your spec: 1. License must be converted to SPDX (and verified): https://codeberg.org/runiq/rpms/src/branch/main/rtirq/rtirq.spec#L7 2. You might consider using %autosetup -p1 instead of %setup and a series of %patch calls: https://codeberg.org/runiq/rpms/src/branch/main/rtirq/rtirq.spec#L32 3. You don't need to clean the buildroot in %install and you should drop the whole %clean section: https://codeberg.org/runiq/rpms/src/branch/main/rtirq/rtirq.spec#L47 https://codeberg.org/runiq/rpms/src/branch/main/rtirq/rtirq.spec#L70 4. systemd macros are in a separate package (systemd-rpm-macros), so there's no need to BR: systemd: https://codeberg.org/runiq/rpms/src/branch/main/rtirq/rtirq.spec#L23 5. I think there's nothing wrong with using /etc/default instead of /etc/sysconfig. Grub and shadow-utils are using that location, so there's a precedent and you could save some patching. 6. The upstream URL returns 404 not found (http://www.rncbc.org/jack/) 7. There's a tarball signature that you could validate: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification If you unretire within a week, you'll be able to claim ownership and start working on it immediately. The package has been retired after being orphaned for 6+ weeks, and if you wait another week, it'll have been retired for 8 weeks, which is the cut-off time for a new review requirement. https://docs.fedoraproject.org/en-US/fesco/Policy_for_orphan_and_retired_packages/#unorphaning_and_unretiring_packages > Thanks for having me :) You are most welcome! Regards, Dominik -- Fedora https://fedoraproject.org Deep in the human unconscious is a pervasive need for a logical universe that makes sense. But the real universe is always one step beyond logic. -- from "The Sayings of Muad'Dib" by the Princess Irulan -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
