On Wed, Feb 14, 2024 at 03:21:38PM +0000, Tom Hughes wrote: > On 14/02/2024 14:54, Richard W.M. Jones wrote: > > >https://src.fedoraproject.org/rpms/rapidjson/pull-request/7 > > > >I don't think what Tom is saying there is correct, or is it? > > The answer is that I'm wrong about it breaking things, because > koji uses the unpacked spec file to install dependencies not the > requires from the srpm. > > However the guidelines whilst not mentioning this case do prohibit > the use of %{_isa} in BRs because it produces incorrect dependencies > in the srpm - the only real difference is that this case give you > a missing dependency rather than a broken one. I was hoping that people with more experience would comment on the bug, and they did, so thanks. The issue we have is that valgrind is simply not a package on RISC-V. Valgrind requires upstream porting work which is only partially complete (and IIRC not upstream yet). I don't know any other way to express this other than using: %ifarch %{valgrind_arches} BuildRequires: valgrind %endif Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
