rpmlint 2.4.0 (in Fedora 39) does not currently support the "%patch -P1 -p1" syntax [1], and incorrectly reports that patches aren't applied. 2.5.0 has a fix for this [2]. There's a 2.5.0 update for F39 currently in testing [3]. [1] https://github.com/rpm-software-management/rpmlint/issues/461#issuecomment-1500993133 [2] https://github.com/rpm-software-management/rpmlint/commit/3631d5f12bf0c26f036e9cfd1bd289c109a09d79 [3] https://bodhi.fedoraproject.org/updates/FEDORA-2024-181fd77b29 Regards, Richard On Tue, 9 Jan 2024 at 17:31, Maxwell G <maxwell@xxxxxxx> wrote: > > Hi everyone, > > RPM has deprecated the `%patchN` syntax in favor of `%patch -PN` where > `N` is the patch number. See the RPM documentation for more information > [1]. In current RPM versions, this syntax only emits a deprecation > warning, but support for this syntax has been removed completely on the > rpm master branch [2]. Around 100 packages maintained by the go-sig > still use this syntax. > > Later this week/early next week, I will run this script [3] over the > affected go-sig packages [4] to update them to the modern patch syntax. > For example, the script will change: > > %patch0 -p1 -> %patch -P0 -p1 > %patch0005 -p2 -> %patch -P0005 -p2 > > If anyone has any objections or would like to exclude a package, please > let me know. > > ---Maxwell > > [1] https://rpm-software-management.github.io/rpm/manual/spec.html#patch-1 > [2] https://github.com/rpm-software-management/rpm/commit/afd352481bacea521ce5ba01e989866478278532 > [3] https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/new_patch_syntax.sh > [4] https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/go-sig/new_patch_syntax/packages > > -- > Maxwell G (@gotmax23) > Pronouns: He/They > -- > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue -- Richard Fearn richardfearn@xxxxxxxxx -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
