Re: fedpkg local - do not clean build directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



V Tue, Jan 17, 2023 at 10:11:48AM +0100, Dan Horák napsal(a):
> On Mon, 16 Jan 2023 21:21:39 -0700
> Orion Poplawski <orion@xxxxxxxx> wrote:
> 
> > How the #$@! do I get fedpkg local to not cleanup the local build 
> > directory after a successful build?  This is the most annoying change to 
> > come around in a long time IMHO.
> 
> hmm, it doesn't clean the build directory here (fedpkg-1.43-2.fc36)
> 
rpmbuild does that:

Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.oNsT7U
+ umask 022
+ cd /home/test/fedora/perl-Fedora-VSP
+ cd Fedora-VSP-0.001
+ /usr/bin/rm -rf /home/test/rpmbuild/BUILDROOT/perl-Fedora-VSP-0.001-29.fc38.x86_64
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(rmbuild): /bin/sh -e /var/tmp/rpm-tmp.WqaIrM
+ umask 022
+ cd /home/test/fedora/perl-Fedora-VSP
+ rm -rf Fedora-VSP-0.001 Fedora-VSP-0.001.gemspec
  ^^^^^^^^^^^^^^^^^^^^^^^
+ RPM_EC=0
++ jobs -p
+ exit 0

From rpm-4.18.0-beta1 changelog:

commit 6f945960affc7a2a2b49337458457273d8a4faf5
Author: Panu Matilainen <pmatilai@xxxxxxxxxx>
Date:   Wed May 25 15:08:30 2022 +0300

    Remove build tree automatically on successfull binary package creation

    Traditionally rpmbuild has only cleaned up the build directory on
    --rebuild mode, but by default leaving tonnes of digital waste behind in
    the far more common -bb mode. Default to cleaning up build directory
    in addition to buildroot on successfull binary package creation,
    with the exception of short-circuit'ed builds.

    To go with this, have --noclean affect the build directory removal too.
    Change the diagnostics message from "--clean" to "rmbuild" because
    --clean is just misleading as it can get executed by other means too.

    (cherry picked from commit b34333fa021c0ee7215714eeef96d1a2843ea08e)

It think "fedpkg local" needs a new "--noclean" option.

-- Petr

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux