On Mon, Jan 16, 2023 at 09:56:31AM +0200, Otto Liljalaakso wrote: > Hello everybody, > > I would like to gather different use cases for the 'fedpkg > scratch-build' command. > > Currently, this is exactly the same as 'fedpkg build --scratch', > meaning that is performs a scratch build of the pushed head of the > current branch. At least in my workflow, I only do scratch builds > before pushing, to ensure that what I am about to push builds > correctly in Koji. Because if this, I never use the default form. > Instead, I always specify 'fedpkg scratch-build --srpm', so that the > srpm to build from is locally generated from the local working > directory. > > What I would like to do is to submit a pull request to either fedpkg > or rpkg, making that the default. It is a single line code change, > not counting changes to documentation and code comments. > > Doing a scratch build from the pushed contents would still be > possible by either a) using 'fedpkg build --scratch' or b) checking > out the remote head and then issuing 'fedpkg scratch-build'. > > Above change seems like a clear improvement to me, making the most > used option the default. But I have noticed that workflows differ > wildly between packagers, so before submitting any code for review, > I would like to hear if somebody regularly uses the default form > 'fedpkg scratch-build' and thinks it currently does the right thing. > > This issue came up when we were updating Package Maintainer Docs > about Koji [1]. > > [1]: https://pagure.io/fedora-docs/package-maintainer-docs/pull-request/101#comment-181487 I always use the --srpm option. I wasn't really aware that there was another possibility, and it doesn't seem very useful. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue